Add the new rating field to the ASN.1 representation as well (I am about to
discover, in a forthcoming commit, that that is in fact a stupid decision).
Move the rating enum definition from message_api.h to pEpEngine.h in order to
make it accessible from message.h . This is temporary anyway: the new rating
engine is coming.
Remove the rating output parameter from decrypt_message. This will temporarily
break *everything*!
_update_state_for_ident_list was not always called with the same last parameter.
Add a boolean parameter to UPDATE_STATE_FOR_IDENT_LIST_AND_JUMP_ON_ERROR in
order to relay it to _update_state_for_ident_list like the original unfactored
code did. I do not fully understand this part, but did not mean to change it.
...Semantics change in decrypt_message:
After factoring the code to fit my smaller mental capacity I noticed that in
case of _status being one of PEP_PASSPHRASE_REQUIRED,
PEP_PASSPHRASE_FOR_NEW_KEYS_REQUIRED or PEP_WRONG_PASSPHRASE, encrypt_message
went to the pEp_error label but in the end returned PEP_STATUS_OK.
I assume this was not intended. Simplify further, using status in the place
of _status. Nothing seems to break.
Instead of bragging about code duplication in comments, factor.
Apart from the change in Bcc handling, this keeps the current semantics... (See
next commit)
Squashed commit of the following:
commit c64d850dc4
Author: Krista Bennett <krista@pep.foundation>
Date: Fri Feb 26 15:29:32 2021 +0100
ENGINE-866: doc'd bit getter function
commit ad725b5b7c
Author: Krista Bennett <krista@pep.foundation>
Date: Fri Feb 26 15:23:49 2021 +0100
ENGINE-866: Key reset tested on mixed sticky and not sticky keys and does what it should.
commit 0ffbdde7b5
Author: Krista Bennett <krista@pep.foundation>
Date: Fri Feb 26 15:13:53 2021 +0100
ENGINE-866: Add boolean for whether to set the sticky bit or not with set_own_imported_key. the adapter should filter this out for apps, I guess, according to Volker
commit 23fec59a9a
Author: Krista Bennett <krista@pep.foundation>
Date: Fri Feb 26 14:53:19 2021 +0100
ENGINE-866: Test and use the sticky bit
commit 562239fda8
Author: Krista Bennett <krista@pep.foundation>
Date: Thu Feb 25 16:47:47 2021 +0100
ENGINE-866: moved bit from key to trust, created set_own_imported_key to replace set_own_key FOR MAIL APPS (does NOT replace it for key reset, as the new function can generate a passphrase error, whereas set_own_key cannot), and did an initial test to ensure the setter/getter functions work on the DB.
commit 594133cfde
Author: Krista Bennett <krista@pep.foundation>
Date: Wed Feb 24 11:16:21 2021 +0100
Commented out the or'd identity.flags / pgp_keypair.flags in the sql code for the get_identity functions; we've never HAD a pgp_keypair flag before, so it never hurt before, but at this point, we're going to introduce them, and I don't want trouble. If fdik wants them or'd, fine, we'll have to change the values in the keyflags to be disjoint from the identity flags so they can coexist, but for now, they are out.
commit 99831445b3
Merge: 8ba53eced1664cf5
Author: Krista Bennett <krista@pep.foundation>
Date: Wed Feb 24 10:15:53 2021 +0100
Merge branch 'master' into ENGINE-866
commit 8ba53ece06
Merge: 168e2cf9c52f4d39
Author: Krista Bennett <krista@pep.foundation>
Date: Mon Feb 22 20:06:08 2021 +0100
Merged in engine_sql changes
commit 168e2cf957
Author: Krista Bennett <krista@pep.foundation>
Date: Mon Feb 22 19:03:35 2021 +0100
ENGINE-866: Added sticky bit in database for manually set keys
