PEMA-54 Roll back the outgoing rating change config

PublicHeaders/PEPObjCAdapter.h

@@ -10,7 +10,6 @@
 
 #import "PEPObjCAdapterConfigurationProtocol.h"
 #import "PEPSession.h"
-#import "PEPNotifyHandshakeDelegate.h"
 #import "PEPSendMessageDelegate.h"
 #import "PEPSync.h"
 #import "NSNumber+PEPRating.h"

PublicHeaders/PEPObjCAdapterEchoConfigurationProtocol.h

@@ -8,8 +8,6 @@
 #ifndef PEPObjCAdapterConfigurationProtocol_Echo_h
 #define PEPObjCAdapterConfigurationProtocol_Echo_h
 
-#import "PEPNotifyHandshakeDelegate.h"
-
 NS_ASSUME_NONNULL_BEGIN
 
 /// Echo protocol configuration across all sessions, including existing ones
@@ -28,14 +26,6 @@ NS_ASSUME_NONNULL_BEGIN
 /// Ping messages from outgoing_message_rating_preview are enabled by default.
 + (void)setEchoInOutgoingMessageRatingPreviewEnabled:(BOOL)enabled;
 
-/// Sets or unsets the global delegate for outgoing rating changes, that usually gets triggered on
-/// decrypting pong messages (part of the echo protocol) via a handshake notification with the reason
-/// of `SYNC_NOTIFY_OUTGOING_RATING_CHANGE`.
-///
-/// @note Even though the engine, and consequently the adapter, reuse handshake notifications
-/// for rating changes, there is no actual connection between the two.
-+ (void)setEchoOutgoingRatingChangeDelegate:(id<PEPNotifyHandshakeDelegate> _Nullable)delegate;
-
 @end
 
 NS_ASSUME_NONNULL_END

src/PEPObjCAdapter+ReadEchoConfig.h

@@ -18,9 +18,6 @@ NS_ASSUME_NONNULL_BEGIN
 + (BOOL)echoProtocolEnabled;
 + (BOOL)echoInOutgoingMessageRatingPreviewEnabled;
 
-/// Gets the currently set delegate for outgoing rating changes, triggered by the processing of echo messages.
-+ (id<PEPNotifyHandshakeDelegate> _Nullable)echoOutgoingRatingChangeDelegate;
-
 @end
 
 NS_ASSUME_NONNULL_END

src/PEPObjCAdapter.m

@@ -44,7 +44,6 @@ static id<PEPPassphraseProviderProtocol> s_passphraseProvider = nil;
 
 static BOOL s_echoProtocolEnabled = YES;
 static BOOL s_echoInOutgoingMessageRatingPreviewEnabled = YES;
-static id<PEPNotifyHandshakeDelegate> s_echoOutgoinRatingChangeDelegate = nil;
 
 static NSArray<PEPMediaKeyPair *> *s_mediaKeys = nil;
 
@@ -127,11 +126,6 @@ static NSArray<PEPMediaKeyPair *> *s_mediaKeys = nil;
     s_echoInOutgoingMessageRatingPreviewEnabled = enabled;
 }
 
-+ (void)setEchoOutgoingRatingChangeDelegate:(id<PEPNotifyHandshakeDelegate> _Nullable)delegate
-{
-    s_echoOutgoinRatingChangeDelegate = delegate;
-}
-
 #pragma mark - Echo Protocol Internal API for Reading
 
 + (BOOL)echoProtocolEnabled
@@ -144,11 +138,6 @@ static NSArray<PEPMediaKeyPair *> *s_mediaKeys = nil;
     return s_echoInOutgoingMessageRatingPreviewEnabled;
 }
 
-+ (id<PEPNotifyHandshakeDelegate> _Nullable)echoOutgoingRatingChangeDelegate
-{
-    return s_echoOutgoinRatingChangeDelegate;
-}
-
 #pragma mark - Media Keys Public API
 
 + (void)configureMediaKeys:(nonnull NSArray<PEPMediaKeyPair *> *)mediaKeys

src/PEPSessionProvider.m

@@ -134,9 +134,6 @@ static PEPInternalSession *s_sessionForMainThread = nil;
 
     BOOL echoInOutgoing = [PEPObjCAdapter echoInOutgoingMessageRatingPreviewEnabled];
     [session configureEchoInOutgoingMessageRatingPreviewEnabled:echoInOutgoing];
-
-    id<PEPNotifyHandshakeDelegate> ratingChangeDelegate = [PEPObjCAdapter echoOutgoingRatingChangeDelegate];
-    // TODO: Set into the session.
 }
 
 + (void)configureMediaKeysOnSession:(PEPInternalSession *)session