err: remove ERR_GET_FUNC()

This is problematic in 3.0 because the function codes are all defined as zero. This leads to either every error matching or no error ever matching. Both are problematic for users. The OTC vote resolved to remove this function completely. Fixes #15946 Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> (Merged from https://github.com/openssl/openssl/pull/16004)
2 years ago · 561e5cda7b
parent ef1e0242a9
commit 561e5cda7b
2 changed files with 0 additions and 6 deletions
--- a/include/openssl/err.h.in
+++ b/include/openssl/err.h.in
@ -247,11 +247,6 @@ static ossl_unused ossl_inline int ERR_GET_LIB(unsigned long errcode)
    return (errcode >> ERR_LIB_OFFSET) & ERR_LIB_MASK;
 }

-static ossl_unused ossl_inline int ERR_GET_FUNC(unsigned long errcode ossl_unused)
-{
-    return 0;
-}
-
 static ossl_unused ossl_inline int ERR_GET_RFLAGS(unsigned long errcode)
 {
    if (ERR_SYSTEM_ERROR(errcode))
--- a/util/other.syms
+++ b/util/other.syms
@ -234,7 +234,6 @@ DTLS_get_link_min_mtu                   define
 DTLS_set_link_mtu                       define
 ENGINE_cleanup                          define deprecated 1.1.0
 ERR_FATAL_ERROR                         define
-ERR_GET_FUNC                            define
 ERR_GET_LIB                             define
 ERR_GET_REASON                          define
 ERR_PACK                                define