#9 add missing #include directives, fixing compilation with GCC

Merged
heck merged 1 commits from LIB-18 into master 7 days ago
positron commented 1 week ago
Collaborator

Tested with GCC 9 and GCC 11.

Tested with GCC 9 and GCC 11.
positron added 1 commit 1 week ago
heck merged commit 634fee3bcd into master 7 days ago
heck commented 7 days ago
Collaborator

Sorry, on mac, where i develop, there is no chance to notice, since clang on mac has different header files structure in which other header can already be included, so...
I always dev on mac, but cant go and test on linux for every little commit. Usually do that before RC/rel. But now that we work on master, the definition is that there is no functional guarantee on an arbitrary commit, not even that it compiles...

Sorry, on mac, where i develop, there is no chance to notice, since clang on mac has different header files structure in which other header can already be included, so... I always dev on mac, but cant go and test on linux for every little commit. Usually do that before RC/rel. But now that we work on master, the definition is that there is no functional guarantee on an arbitrary commit, not even that it compiles...
The pull request has been merged as 634fee3bcd.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.