pEp.foundation
/
libpEpAdapter
10
1
Fork 4
Code Issues Pull Requests 1 Releases 65 Activity
Labels Milestones
New Pull Request

#9 add missing #include directives, fixing compilation with GCC

Merged
heck merged 1 commits from LIB-18 into master 7 days ago
Conversation 1 Commits 1 Files Changed 2
positron commented 1 week ago
Collaborator

Tested with GCC 9 and GCC 11.

Tested with GCC 9 and GCC 11.
positron added 1 commit 1 week ago
heck merged commit 634fee3bcd into master 7 days ago
heck commented 7 days ago
Collaborator

Sorry, on mac, where i develop, there is no chance to notice, since clang on mac has different header files structure in which other header can already be included, so...
I always dev on mac, but cant go and test on linux for every little commit. Usually do that before RC/rel. But now that we work on master, the definition is that there is no functional guarantee on an arbitrary commit, not even that it compiles...

Sorry, on mac, where i develop, there is no chance to notice, since clang on mac has different header files structure in which other header can already be included, so... I always dev on mac, but cant go and test on linux for every little commit. Usually do that before RC/rel. But now that we work on master, the definition is that there is no functional guarantee on an arbitrary commit, not even that it compiles...
The pull request has been merged as 634fee3bcd.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'LIB-18'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes