#11 DPE-62 Fix build for Windows.

Merged
huss merged 2 commits from Ignacio/libpEpTransport:DPE-62 into master 7 months ago
Ignacio commented 7 months ago
There is no content yet.
Ignacio added 2 commits 7 months ago
Ignacio force-pushed DPE-62 from d532a75f28 to f14444b964 7 months ago
Ignacio force-pushed DPE-62 from f14444b964 to b9c34b236b 7 months ago
Ignacio force-pushed DPE-62 from b9c34b236b to eecb71b729 7 months ago
at reviewed 7 months ago
at left a comment

Regarding the change for "build-gradle/transport/build.gradle" file, if you are trying to identify the build environment between Linux, Unix, Windows and OS X Operating Systems where the built process is taking place so using org.gradle.internal.os.OperatingSystem makes sense but if you would like to identify some other OS's then you can use the Gradle nativeplatform.platform.OperatingSystem interface which includes FreeBSD and Solaris Operating Systems.

at requested changes 7 months ago
at left a comment

Regarding the change introduced for "build-windows/generate_code.cmd" file when setting yml2_directory variable, you are adding an extra backslash that it is not causing any error and it is successfully working but it is unnecessary since current_directory variable is already adding a trailing backslash so it can be removed. So you can replace:

SET yml2_directory=%current_directory%\..\..\..\pEpForWindowsAdapterSolution\yml2

by

SET yml2_directory=%current_directory%..\..\..\pEpForWindowsAdapterSolution\yml2

Ignacio force-pushed DPE-62 from eecb71b729 to 4a4ba06fe2 7 months ago
at approved these changes 7 months ago
huss reviewed 7 months ago
build-gradle/transport/build.gradle
exec {
def command = ['make', 'all']
workingDir "../../src"
commandLine command
huss commented 7 months ago

Test comment

Test comment
huss marked this conversation as resolved
huss merged commit e4fe7310d1 into master 7 months ago

Reviewers

at approved these changes 7 months ago
The pull request has been merged as e4fe7310d1.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.