ENGINE-174 this should fix side effects on Sync - take key comm_type instead of least_trust when trust is not set

src/message_api.c

@@ -789,7 +789,6 @@ static PEP_rating decrypt_rating(PEP_STATUS status)
 
 static PEP_rating key_rating(PEP_SESSION session, const char *fpr)
 {
-    PEP_comm_type bare_comm_type = PEP_ct_unknown;
 
     assert(session);
     assert(fpr);
@@ -797,20 +796,20 @@ static PEP_rating key_rating(PEP_SESSION session, const char *fpr)
     if (session == NULL || fpr == NULL)
         return PEP_rating_undefined;
 
+
+    PEP_comm_type bare_comm_type = PEP_ct_unknown;
     PEP_STATUS status = get_key_rating(session, fpr, &bare_comm_type);
     if (status != PEP_STATUS_OK)
         return PEP_rating_undefined;
 
-    /* FIXME: All this tells us is that the bare key is ok. It's
-       fine to check - if there's something wrong with the key in
-       the keyring we should probably do something about it -
-       but it doesn't deal with overall trust. We also need 
-       trust in here. */
-    
     PEP_comm_type least_trust_type = PEP_ct_unknown;
-    status = least_trust(session, fpr, &least_trust_type);
+    least_trust(session, fpr, &least_trust_type);
 
-    return _rating(least_trust_type, PEP_rating_undefined);
+    if (least_trust_type == PEP_ct_unknown) {
+        return _rating(bare_comm_type, PEP_rating_undefined);
+    } else {
+        return _rating(least_trust_type, PEP_rating_undefined);
+    }
 }
 
 static PEP_rating worst_rating(PEP_rating rating1, PEP_rating rating2) {

src/pEpEngine.c

@@ -90,7 +90,10 @@ static const char *sql_get_trust =
     "and pgp_keypair_fpr = upper(replace(?2,' ','')) ;";
 
 static const char *sql_least_trust = 
-    "select min(comm_type) from trust where pgp_keypair_fpr = upper(replace(?1,' ','')) ;";
+    "select min(comm_type) from trust where"
+    " pgp_keypair_fpr = upper(replace(?1,' ',''))"
+    " and comm_type != 0;"; // ignores PEP_ct_unknown
+    // returns PEP_ct_unknown only when no known trust is recorded
 
 static const char *sql_mark_as_compromized = 
     "update trust not indexed set comm_type = 15"
@@ -1425,6 +1428,7 @@ DYNAMIC_API PEP_STATUS least_trust(
             break;
         }
         default:
+            // never reached because of sql min()
             status = PEP_CANNOT_FIND_IDENTITY;
     }