warnings with clang

src/keymanagement.c

@@ -262,7 +262,7 @@ DYNAMIC_API PEP_STATUS do_keymanagement(
 
     log_event(session, "keymanagement thread started", "pEp engine", NULL, NULL);
 
-    while (identity = retrieve_next_identity(management)) {
+    while ((identity = retrieve_next_identity(management))) {
         assert(identity->address);
         log_event(session, "do_keymanagement", "debug", identity->address, NULL);
         if (identity->me) {

src/transport.c

@@ -42,6 +42,8 @@ pEp_identity *identity_dup(const pEp_identity *src)
     dup->lang[1] = src->lang[1];
     dup->lang[2] = 0;
     dup->me = src->me;
+
+    return dup;
 }
 
 identity_list *new_identity_list(const pEp_identity *ident)