So, uh, it turns out argument order is important. Who knew? Fixed get_identity calls which would have impacted ratings when update_identity gets called without a user_id (which means it also impacts own_identities called without an own user id or .me set)

5 years ago · c11cf1d3f0
parent 45b6cc7736
commit c11cf1d3f0
1 changed files with 3 additions and 3 deletions
--- a/src/keymanagement.c
+++ b/src/keymanagement.c
@ -587,8 +587,8 @@ DYNAMIC_API PEP_STATUS update_identity(
        
        if (default_own_id) {
            status = get_identity(session, 
-                                  default_own_id, 
                                  identity->address, 
+                                  default_own_id, 
                                  &stored_ident);
        }
        // If there isn't an own identity, search for a non-temp stored ident
@ -667,8 +667,8 @@ DYNAMIC_API PEP_STATUS update_identity(
         
        if (default_own_id) {
            status = get_identity(session, 
-                                  default_own_id, 
                                  identity->address, 
+                                  default_own_id, 
                                  &stored_ident);
        }
        // If there isn't an own identity, search for a non-temp stored ident
@ -1627,7 +1627,7 @@ DYNAMIC_API PEP_STATUS set_own_key(
    
    pEp_identity* my_id = NULL;
    
-    status = get_identity(session, my_user_id, address, &my_id);
+    status = get_identity(session, address, my_user_id, &my_id);

    if (status == PEP_STATUS_OK && my_id) {
        if (my_id->fpr && strcasecmp(my_id->fpr, fpr) == 0) {