Commit Graph

292 Commits (6741a6c735179b8e2db38af42a102ba2b9ceb1e7)

Author SHA1 Message Date
Roker 3fa5af32a6 merge "default" into my branch
6 years ago
Edouard Tisserant 40e6fb92ec ENGINE-183 more fixes
6 years ago
Roker 07ce93a741 merge "default" into "ENGINE-199"
6 years ago
Edouard Tisserant 3a5010ac24 ENGINE-183 remove session.use_only_own_private_keys, and add existing priv keys to own_keys table at initial startup. Also added fpr from own_keys to own_key_is_listed, influencing result of ellect_own_key.
6 years ago
Edouard Tisserant 99a13d5e71 update_identity() now takes PEP_ct_key_expired as a special case, and replaces it with actual key rating if not expired enymore. Otherwise, partner's rating with expired key was never comming back to normal, even if key was renewed.
6 years ago
Roker 499528818f add more ERROR() and GOTO() to find out why the call failed. it is in keymanagement.c :-D
6 years ago
Krista Grothoff 6e01c347d8 gpg and internal API changes for ENGINE-172 implemented and tested (no-sign); no-key not in yet
6 years ago
Roker bbe403a3bb avoid unitialized local pointer variables to reduce hard-to-find bugs
6 years ago
Krista Grothoff a7f6929b99 Removed assert, because an empty username is totally valid input from an email, and we deal with it directly in the code that follows where the assert was.
6 years ago
Edouard Tisserant 69a3d474ed ENGINE-137 (fixing side effect of optimization) update_identity: added key re-election when a key has been deleted from keyring. fixed test blacklist_accept_new_key_test using that feature
6 years ago
Volker Birk e4cfb490c6 adding license info to each file
6 years ago
Edouard Tisserant 143760e389 ENGINE-137 fix optimization of update_identity, elect_pubkey already does blacklisted key exclusion, no need to redo it here.
6 years ago
Edouard Tisserant f504dc8506 ENGINE-137 3x optimization in update_identity, though it breaks blacklist test. To be continued
6 years ago
Krista Grothoff c062591bc5 Fixed additional null username issue in update_identity
6 years ago
Edouard Tisserant ab6e55446e Prevent assertion when username is not given for own identity, and doing keygen
6 years ago
Krista Grothoff 59ad29f6f0 merged in default
6 years ago
Krista Grothoff d5e3d94e83 ENGINE-112: updated get_trust in update_identity and stopped set_identity from setting empty fprs as keypairs and trust entries
6 years ago
Edouard Tisserant 40224d7ce2 Copy-paste is bad.
6 years ago
Edouard Tisserant 857449c676 ENGINE-140 clean'up own_identities_retrieve so that available pEpEngine API returns all own identities, not only those that can be synced
6 years ago
Edouard Tisserant db4696a34a ENGINE-140 changed identities flags update policy
6 years ago
Edouard Tisserant 601a5f7ce7 ENGINE-140 #comment Added own_keys table, linking pgp_keypair to identity in case user_id = PEP_OWN_USERID.
6 years ago
Edouard Tisserant f82c4f2c7b No more _update_indentiy() and with_myself parameter. Rather, added a _myself(), with a do_keygen parameter. Now, only explicit call to myself(), key_mistrusted(), encrypt_message(), encrypt_message_to_self() may trigger keygen, not outgoing_message_rating() or update_identity()
6 years ago
Krista Grothoff 805480adf6 ENGINE-84: fixed merge conflicts
6 years ago
Krista Grothoff c494b41aa3 ENGINE-84: merge with default
6 years ago
Edouard Tisserant f173c2d243 fixed memory leak in myself
6 years ago
Edouard Tisserant 969ac0b290 ENGINE-140: now send all keys that have been at some point used as own key _on that device_
6 years ago
Krista Grothoff bba7e41310 ENGINE-84: fixed status TODOs.
6 years ago
Volker Birk e843fdb577 missing install files fixed
6 years ago
Krista Grothoff 7ee6f7aeec ENGINE-84: #comment now generating new keys when no usable private key is available, and not electing/selecting/attempting to use own keys as private keys where private half of the keypair is blacklisted, revoked, or missing. TODO: fix status TODOs, test more before merging back. But it's working, in general.
6 years ago
Krista Grothoff a00aca8f99 ENGINE-84: merged in default
6 years ago
Krista Grothoff 123ba933e4 ENGINE-84: working on ensuring keypairs missing private keys are not selected for encryption candidates
6 years ago
Krista Grothoff 01ea05e22e Fixed problem with null usernames coming from prepackaged mime messages in 'From' for MIME_encrypt_message
6 years ago
Krista Grothoff c6aee70900 stowing changes
6 years ago
Krista Grothoff 19f553d85a ENGINE-129: update_identity now properly returns an ID with an empty fpr string when no key can be elected because none are in the keyring
6 years ago
Edouard Tisserant 127f50303e sync: decrypt_message and myself shouldn't return sync errors except if out of memory
7 years ago
Edouard Tisserant 5b3f3cbb44 Deleted 'useless extraneous code that got pulled over from an earlier version', according to darthmama
7 years ago
Krista Grothoff 64906852a6 ENGINE-112: #comment Fixed empty fpr problems in stored identities which occurred due to blacklisting. When adding other keys, we now check to see if there is a matching identity entry which lacks an fpr and, if so, we update it instead of adding a new one. Also fixed elect_pubkey NOT to return blacklisted pubkeys.
7 years ago
Edouard Tisserant 414e24e242 deleted unused _same_fpr() causing a warning in keymanagement.c
7 years ago
Krista Grothoff 21acdf33fa Actually, the flag was correct. Sigh.
7 years ago
Krista Grothoff 7ceb9fee62 don't_use_fpr was always set to true in update_identity. Fixed.
7 years ago
Krista Grothoff 0c39fa468c include in keymanagement.c for blacklist_is_listed
7 years ago
Krista Grothoff c49a6aecb7 ENGINE-107: added ct and rating states for having no key
7 years ago
Roker 3ab3c15da6 merge "default" into "keysync" to keep them in sync
7 years ago
Krista Grothoff 1e54cadadd ENGINE-27: set_identity can be called with a null/empty fpr now per Volker. ensured it does not call blacklist_is_listed on null/empty fprs
7 years ago
Krista Grothoff 19a1b40502 ENGINE-27: set_identity can be called with a null/empty fpr now per Volker. ensured it does not call blacklist_is_listed on null/empty fprs
7 years ago
Krista Grothoff 8872288526 ENGINE-27: ensure set_identity doesn't get called in update_identity if the fpr is null
7 years ago
Krista Grothoff 7c7e80dd89 ENGINE-27: blacklist_is_listed will no longer be called with empty/null strings in update_identity (caused assert failure)
7 years ago
Krista Grothoff 224e210f7c ENGINE-96: #comment all calls renamed. Roker is checking out the semantics of the references to 'compromized' to see if they also need to be renamed to 'mistrusted' for consistency within the engine. THIS IS AN API CHANGE AND WILL BREAK ADAPTERS.
7 years ago
Krista Grothoff 399c421c5e ENGINE-27: #comment I forgot one possible blacklist case. If you still get an assertion fail, I'd appreciate capturing the error type if you can so I can follow the logic. Please pull and try again...
7 years ago
Edouard Tisserant ee8eccb069 Sync : asynchronously inject KeyGen and CannotDecrypt to fsm
7 years ago
Krista Grothoff 2e4b7f75f3 ENGINE-27: type
7 years ago
Krista Grothoff a11b7e7ee1 ENGINE-27: setting fpr to empty string, not NULL, so set_identity doesn't crash.
7 years ago
Krista Grothoff 34fa1f2a83 ENGINE-27: intermittent commit, update_identity should now never try to set or return a blacklisted key
7 years ago
Krista Grothoff acad8e0a08 ENGINE-27: update_identity no longer pays attention to the input identity's fpr, but pulls one from elect_pubkey.
7 years ago
Roker 1d2ae094b2 merge "default" into "keysync" branch
7 years ago
Edouard Tisserant 66a97e2c20 ENGINE-94 Workaround key-election not being stored in case of expired key
7 years ago
Edouard Tisserant a3804f15b9 KeyGen state injection should happen only when key have been generated...
7 years ago
Edouard Tisserant 2cf840e4e7 moved KeyGen state injection from generate_keypair() to the bottom of myself() (in case of successfull keygen), thus ensuring that new identity has been already created when starting to multicast beacons to all own identities.
7 years ago
Volker Birk ccb25c2ea6 freeing what could not be added
7 years ago
Volker Birk f6a473389c adding onomem safeguard
7 years ago
Volker Birk f233a934d6 ...
7 years ago
Volker Birk 91e5b7da91 own_identities_retrieve() bullet proof
7 years ago
Volker Birk c0f9e61b8c BUGFIX: user_id and username
7 years ago
Volker Birk b0bed36c00 own identities have me flag set
7 years ago
Volker Birk eae4c92185 adding get_own_addresses()
7 years ago
Volker Birk becce8c271 empty address allowed for myself()
7 years ago
Volker Birk be18b1c198 update_identity(): if no user_id then have a look if it is an own identity first, and if so call myself()
7 years ago
Volker Birk 97711e429c BUGFIX: user_id cropped
7 years ago
Volker Birk 309b5d4ed4 BUGFIX: user_id cropped
7 years ago
Volker Birk c8fd579fca ...
7 years ago
Volker Birk 7474af98bf adding set_identity_flags_test
7 years ago
Volker Birk ff6283c288 adding set_identity_flags()
7 years ago
Volker Birk e767049511 missing assert
7 years ago
Edouard Tisserant 87b67659c3 fix #30 : memleak in myself(): stored_identity is never freed in keymanagement.c
7 years ago
Edouard Tisserant 444cc650ac Myself() : elect another pre-existing private key if stored own identity key have been removed from GPG keyring (Outlook+GPA case)
7 years ago
Edouard Tisserant 7ec1bdf077 Moved myself() own key election to a separate function
7 years ago
Edouard Tisserant 76a01b7f9e trying to get a better key in update_identity, when existing key has been revoked
7 years ago
Edouard Tisserant 6a9f9bb0f5 fixing use_only_own_private_keys build
7 years ago
Edouard Tisserant cdc6a9d4a1 added use_only_own_private_keys (testing)
7 years ago
Edouard Tisserant ce79f22bda Test for expiry one week before it happens
7 years ago
Edouard Tisserant 438a873575 Revocation-related fixes
7 years ago
Edouard Tisserant 1b14e9b72d Myself records replaced revoked key when generating a new key to replace revoked key
7 years ago
Edouard Tisserant 7fd416a99e Attach_own_key also attach revoke for some time after revocation
7 years ago
Volker Birk d40a4dee65 no if no typo :-P
7 years ago
Volker Birk c09351c9c8 typo
7 years ago
Volker Birk ae2bd5c4a8 bugfix
7 years ago
Edouard Tisserant 12a7477ed6 Remove own_keys table, added PEP_OWN_USERID, unique person userId for any own identities and keys.
7 years ago
Volker Birk 8ce0490ab8 remove size fields of pEp_identity
7 years ago
Edouard Tisserant d5708d03a2 Own keys, now filled and used by myself()
7 years ago
Edouard Tisserant 8e953a1aa7 Own keys (SQL and accessors functions)
7 years ago
Edouard Tisserant 1f5fd47a86 Removed get_best_user, leading to unexpected behaviour when user_id is made null again, for example when corresponding app contact is deleted
7 years ago
Edouard Tisserant a926501109 Made myself() re-use already selected fpr from pre-existing identity if not explicitely given. More restriction while selecting gpg ring's key should still be enforced.
7 years ago
Edouard Tisserant c3e8184c7e Fixed Primary Key of identity table. Was (address) and know is (address, user_id). Added 'virtual' user_id (const string + address) as a side effect, in case user_id isn't given and no user have been created with same address.
7 years ago
Edouard Tisserant b96e16d1c9 Fixed infinite loop in keymanagement.c/_same_fpr(), when fingerprints are different
7 years ago
Volker Birk ab96ae5b31 delete from stringlist
7 years ago
Volker Birk 1261836024 merging
7 years ago
Edouard Tisserant 8d097207fb Comparing fingerprints now accepts spaces and upper and lower case
7 years ago
Volker Birk 9335495d8f delete key references if key is added to blacklist
7 years ago
Lars Rohwedder 7133bd5d71 remove unused MIN, fix () on EMPTYSTR macro
7 years ago
Edouard Tisserant ba77eb0409 Fixed #32 : assert(keylist) without if in keymanagement.c:238
7 years ago
Edouard Tisserant 30bcdcae0a Ticket #28 : improvement: keymanagement.c: update_identity(): strndup instead of strdup (size is known)
7 years ago
Volker Birk 7fc7f3989d SNAFU
7 years ago
Edouard Tisserant b24bcf1b72 Prevent changing identity's fpr when new fpr trust level is lower
7 years ago
Edouard Tisserant ec50919ebd Reworked logic in update_identity, when identity->fpr is provided
7 years ago
Edouard Tisserant e1f50fc25d Backed out changeset a460b5ce0d6e
7 years ago
Edouard Tisserant 0f97e81397 update_identity doesn't try to apply given comm_type anymore.
7 years ago
Edouard Tisserant c1cfc761f2 intermediate state, implementing mistrust
7 years ago
Edouard Tisserant 8805497f69 Renamed EMPTY macro to EMPTYSTR, conflicting with some apple includes, and then being always 0
7 years ago
Volker Birk be58c17c0c sparing a call
7 years ago
Volker Birk 1c9399e8d1 An undo is possible for keys we don't own, and therefore have not revoked.
7 years ago
Volker Birk afe4a07cd7 key_reset_trust() can reset trust_personal_key() only.
7 years ago
Edouard Tisserant 3ca28f148f Added key_reset_trust, accepting identity instead of fpr
7 years ago
Edouard Tisserant 7a8d043aa9 Fixed typo. Are all *_size members of identity struct really used ?
7 years ago
Edouard Tisserant 76ff681231 Code can die twice
7 years ago
Edouard Tisserant 5d168b5451 Was that dead code ?
7 years ago
Volker Birk 920e568497 very small type error, nothing to blame important people for, or even friends
8 years ago
Edouard Tisserant 040a982082 Fixed double free and unprotected NULL dereferencing.
8 years ago
Volker Birk 331539c3aa PEP_CANNOT_SET_TRUST added
8 years ago
Volker Birk b18b0ee923 key_compromized() added
8 years ago
Volker Birk e5b22b4d94 only what is yellow can be green
8 years ago
Volker Birk 8497834daa adding trust_personal_key()
8 years ago
Volker Birk 87223ae4f0 better policy
8 years ago
Volker Birk 9bd721405c bugfix
8 years ago
Volker Birk 4408dbb1dd examine callback
8 years ago
Volker Birk e27f9a1425 adding missing functions in GPGME
8 years ago
Volker Birk 20efb6b7ee ...
8 years ago
Volker Birk fda2b73599 ...
8 years ago
Volker Birk 6217a2f22b DEBUG_LOG() for keymanagement
8 years ago
Volker Birk 2cb54a7ec1 DEBUG_LOG() for keymanagement
8 years ago
Volker Birk 0e4d12d226 checking if own key is expired and renew it
8 years ago
Volker Birk 808615adf8 safety
8 years ago
Volker Birk f7233d42ab modifications for Windoze
8 years ago
vb 3bb5d2377a strncasecmp(3)
8 years ago
vb 079cd03b56 BUGFIX: init of transports wrong
8 years ago
vb be6a61d80f warnings with clang
8 years ago
vb 4b94f3c410 ...
9 years ago
vb f1889d55ad bugfix: update_identity
9 years ago
vb 5abda13db7 bugfix: when identity is not stored yet, update_identity failes
9 years ago
vb 1369846eee ...
9 years ago
vb 6a6d2eb64f ...
9 years ago
vb af6c3b757e moving functionality into pEpEngine
9 years ago
vb 7feceb3f9f initial commit
9 years ago