pEp.foundation
/
pEpEngine
15
2
Fork 17
Code Issues 21 Pull Requests 1 Projects 2 Releases 52 Wiki Activity

Labels Milestones

Cleanup makefile for ASN.1 #34

Merged
darthmama merged 2 commits from htgoebel/pEpEngine:cleanup-makefile into master 2 years ago
Conversation 0 Commits 2 Files Changed 1
htgoebel commented 2 years ago

This does two things:

  • remove redudacy in asn.1 Makefile
  • Remove anoyance that after running "make -C asn.1 clean" one needed to run "rm codegen/.copy && make -C codegen" to get the generated files. Now "make -C asn.1" is enough (some overhead involved, but fixing this requires quite some changes to the codegen Makefile)

Nothing else should be effected.

This does two things: - remove redudacy in asn.1 Makefile - Remove anoyance that after running "make -C asn.1 clean" one needed to run "rm codegen/.copy && make -C codegen" to get the generated files. Now "make -C asn.1" is enough (some overhead involved, but fixing this requires quite some changes to the codegen Makefile) Nothing else should be effected.
htgoebel added 2 commits 2 years ago
f94a029b41 asn1: Cleanup Makefile. 
* Use variables to remove redundant listing of ASN.1 file names.
* Use variables to remove redundant naming of asn1c options.
* Use automatic variable "$+" when running asn1c to avoid redundantly
  listing all dependencies again. (This variable is a GNU make extension.)
bebb63354b asn1: Add Makefle target for generated files. 
This copies in the generated files from ../codegen/ if missing.
This allows to run "make -C asn.1 clean all"
darthmama merged commit e43bc9d05a into master 2 years ago
The pull request has been merged as e43bc9d05a.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b htgoebel-cleanup-makefile master
git pull cleanup-makefile

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff htgoebel-cleanup-makefile
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pEp.foundation/pEpEngine#34
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'htgoebel/pEpEngine:cleanup-makefile'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes