we will never see this in any of the makefiles we maintain:
Maybe write that down somewhere? Though tbh I have no idea where one would write that down, so maybe it is there already. Maybe also write down where such things are written down... Front page of https://dev.pep.security/ maybe?
Well, JSON-193 and this PR where kind of concurrent. But yes, things do get written down, and that is great!
And no, I am not part of the adapter team, I am not in any way responsible for that, but it is still very much my problem. I guess I was in a deployment role for a while, but also as a developer, I need to compile adapters on sometimes weird platforms and that involves fixing the Makefiles as required. I could open a ticket for each of the problems, but fixing it myself is just much faster.
So that might explain why I am not aware of the Adapter Makefile conventions, and that is I think a very good reason why they should be documented in an easy to find place (which, ofc, we need to agree on company/project wide).
Ofc this is really not at all about the changes in this PR and also not really just about adapter Makefiles. More like, in general, documentation is not for the people who have to deal with sth. every day (they tend to know stuff), but for the people for whom whatever is just yet another thing that needs to get out of the way before the actual work can start.