import_key: enrich return value, adding the list of imported FPRs #14

Merged
heck merged 1 commits from positron/improve-import_key into master 2 months ago
Owner

Before this change there was no way of knowing the FPR of a key being imported from a file, for example this way:

import pEp
pEp.import_key(open('/home/luca/pep-src/engine-user/keys/bob-pub.asc').read())

The result of pEp.import_key was a list of affected identities.

This change enriches the result, now a tuple containing:

  • the list of affected identities, as before;
  • the list of imported FPRs, as a list of strings.

This is in theory an incompatible change but I do not see the result of import_key being ever used. The new result will be quite useful to me, and probably to @nkls as well.

Before this change there was no way of knowing the FPR of a key being imported from a file, for example this way: import pEp pEp.import_key(open('/home/luca/pep-src/engine-user/keys/bob-pub.asc').read()) The result of `pEp.import_key` was a list of affected identities. This change enriches the result, now a tuple containing: * the list of affected identities, as before; * the _list of imported FPRs_, as a list of strings. This is in theory an incompatible change but I do not see the result of `import_key` being ever used. The new result will be quite useful to me, and probably to @nkls as well.
positron added 1 commit 2 months ago
Poster
Owner

And, @heck, I hope it is okay for me to create branches in the positron/ namespace. I can delete them after they are merged.

And, @heck, I hope it is okay for me to create branches in the `positron/` namespace. I can delete them after they are merged.
heck merged commit 5ea242d577 into master 2 months ago
heck deleted branch positron/improve-import_key 2 months ago
Poster
Owner

Thanks!

Thanks!
The pull request has been merged as 5ea242d577.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pEp.foundation/pEpPythonAdapter#14
Loading…
There is no content yet.